Data Testing To Prevent Saving Bad Data

I set up the following code listed below. The form is set up as a
multi-record form (Default View = Continuous Forms). The test is successful
on existing records preventing the user from going forward. When a new
record is added, the user can beat the system by clicking on the next line
and then clicking the save icon on the tool bar. Can the system be set up in
such a way that if the user adds a new record and the test fails, that he is
prevented from saving the record or even going to the next line by clicking
the mouse. Could the toolbar be disabled, preventing the user from being
able to save when the test fails ? Is any other code required in the
BeforeUpdate procedure to prevent the user from going forward until the error
is addressed ?

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
Cancel = MsgBox("You must enter an HR number.", vbCritical, "Data
Validation Failure")
End
End Sub

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
MsgBox "You must enter an HR number.", vbCritical, "Data Validation
Failure"
Cancel = True
End Sub

The value of vbCancel is 2
The value of True is -1

"rmcompute" wrote in message
...
I set up the following code listed below. The form is set up as a
multi-record form (Default View = Continuous Forms). The test is
successful
on existing records preventing the user from going forward. When a new
record is added, the user can beat the system by clicking on the next line
and then clicking the save icon on the tool bar. Can the system be set up
in
such a way that if the user adds a new record and the test fails, that he
is
prevented from saving the record or even going to the next line by
clicking
the mouse. Could the toolbar be disabled, preventing the user from being
able to save when the test fails ? Is any other code required in the
BeforeUpdate procedure to prevent the user from going forward until the
error
is addressed ?

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
Cancel = MsgBox("You must enter an HR number.", vbCritical, "Data
Validation Failure")
End
End Sub

i tested your code on a Continuous form, and it ran consistently no matter
what i did to "save" either a new record or an edit to an existing record -
pressing Shift+Enter, or clicking the toolbar icon, or choosing menu Records
| Save record, or moving to another record - either next or previous, or
closing the form. this is the expected result.

are you sure that the new record is actually being saved when you "move to
another record and click the Save icon"? what version of Access are you
using? and is any other code running on the form's BeforeUpdate event?

hth


"rmcompute" wrote in message
...
I set up the following code listed below. The form is set up as a
multi-record form (Default View = Continuous Forms). The test is
successful
on existing records preventing the user from going forward. When a new
record is added, the user can beat the system by clicking on the next line
and then clicking the save icon on the tool bar. Can the system be set up
in
such a way that if the user adds a new record and the test fails, that he
is
prevented from saving the record or even going to the next line by
clicking
the mouse. Could the toolbar be disabled, preventing the user from being
able to save when the test fails ? Is any other code required in the
BeforeUpdate procedure to prevent the user from going forward until the
error
is addressed ?

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
Cancel = MsgBox("You must enter an HR number.", vbCritical, "Data
Validation Failure")
End
End Sub

When I re-tested, it seemed to work; I guess I had been working too long.
Thank you.



"tina" wrote:

i tested your code on a Continuous form, and it ran consistently no matter
what i did to "save" either a new record or an edit to an existing record -
pressing Shift+Enter, or clicking the toolbar icon, or choosing menu Records
| Save record, or moving to another record - either next or previous, or
closing the form. this is the expected result.

are you sure that the new record is actually being saved when you "move to
another record and click the Save icon"? what version of Access are you
using? and is any other code running on the form's BeforeUpdate event?

hth


"rmcompute" wrote in message
...
I set up the following code listed below. The form is set up as a
multi-record form (Default View = Continuous Forms). The test is
successful
on existing records preventing the user from going forward. When a new
record is added, the user can beat the system by clicking on the next line
and then clicking the save icon on the tool bar. Can the system be set up
in
such a way that if the user adds a new record and the test fails, that he
is
prevented from saving the record or even going to the next line by
clicking
the mouse. Could the toolbar be disabled, preventing the user from being
able to save when the test fails ? Is any other code required in the
BeforeUpdate procedure to prevent the user from going forward until the
error
is addressed ?

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
Cancel = MsgBox("You must enter an HR number.", vbCritical, "Data
Validation Failure")
End
End Sub

no problem


"rmcompute" wrote in message
...
When I re-tested, it seemed to work; I guess I had been working too long.
Thank you.



"tina" wrote:

i tested your code on a Continuous form, and it ran consistently no
matter
what i did to "save" either a new record or an edit to an existing
record -
pressing Shift+Enter, or clicking the toolbar icon, or choosing menu
Records
| Save record, or moving to another record - either next or previous, or
closing the form. this is the expected result.

are you sure that the new record is actually being saved when you "move
to
another record and click the Save icon"? what version of Access are you
using? and is any other code running on the form's BeforeUpdate event?

hth


"rmcompute" wrote in message
...
I set up the following code listed below. The form is set up as a
multi-record form (Default View = Continuous Forms). The test is
successful
on existing records preventing the user from going forward. When a
new
record is added, the user can beat the system by clicking on the next
line
and then clicking the save icon on the tool bar. Can the system be
set up
in
such a way that if the user adds a new record and the test fails, that
he
is
prevented from saving the record or even going to the next line by
clicking
the mouse. Could the toolbar be disabled, preventing the user from
being
able to save when the test fails ? Is any other code required in the
BeforeUpdate procedure to prevent the user from going forward until
the
error
is addressed ?

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
Cancel = MsgBox("You must enter an HR number.", vbCritical, "Data
Validation Failure")
End
End Sub

Your code DOES NOT work!!!!

"rmcompute" wrote in message
...
When I re-tested, it seemed to work; I guess I had been working too long.
Thank you.



"tina" wrote:

i tested your code on a Continuous form, and it ran consistently no
matter
what i did to "save" either a new record or an edit to an existing
record -
pressing Shift+Enter, or clicking the toolbar icon, or choosing menu
Records
| Save record, or moving to another record - either next or previous, or
closing the form. this is the expected result.

are you sure that the new record is actually being saved when you "move
to
another record and click the Save icon"? what version of Access are you
using? and is any other code running on the form's BeforeUpdate event?

hth


"rmcompute" wrote in message
...
I set up the following code listed below. The form is set up as a
multi-record form (Default View = Continuous Forms). The test is
successful
on existing records preventing the user from going forward. When a new
record is added, the user can beat the system by clicking on the next
line
and then clicking the save icon on the tool bar. Can the system be set
up
in
such a way that if the user adds a new record and the test fails, that
he
is
prevented from saving the record or even going to the next line by
clicking
the mouse. Could the toolbar be disabled, preventing the user from
being
able to save when the test fails ? Is any other code required in the
BeforeUpdate procedure to prevent the user from going forward until the
error
is addressed ?

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
Cancel = MsgBox("You must enter an HR number.", vbCritical, "Data
Validation Failure")
End
End Sub

Pat, i tested rmcompute's code in an A2K db running in A2003 on OS Win2KPro.
i pasted it "as is" from his post, changing only the control name HRnum to
the name of a control on my form. the code runs fine on my setup. did you
have a different result? perhaps in another version of Access or Windows?

hth


"Pat Hartman(MVP)" wrote in message
...
Your code DOES NOT work!!!!

"rmcompute" wrote in message
...
When I re-tested, it seemed to work; I guess I had been working too
long.
Thank you.



"tina" wrote:

i tested your code on a Continuous form, and it ran consistently no
matter
what i did to "save" either a new record or an edit to an existing
record -
pressing Shift+Enter, or clicking the toolbar icon, or choosing menu
Records
| Save record, or moving to another record - either next or previous,
or
closing the form. this is the expected result.

are you sure that the new record is actually being saved when you "move
to
another record and click the Save icon"? what version of Access are you
using? and is any other code running on the form's BeforeUpdate event?

hth


"rmcompute" wrote in message
...
I set up the following code listed below. The form is set up as a
multi-record form (Default View = Continuous Forms). The test is
successful
on existing records preventing the user from going forward. When a
new
record is added, the user can beat the system by clicking on the next
line
and then clicking the save icon on the tool bar. Can the system be
set
up
in
such a way that if the user adds a new record and the test fails,
that
he
is
prevented from saving the record or even going to the next line by
clicking
the mouse. Could the toolbar be disabled, preventing the user from
being
able to save when the test fails ? Is any other code required in the
BeforeUpdate procedure to prevent the user from going forward until
the
error
is addressed ?

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
Cancel = MsgBox("You must enter an HR number.", vbCritical, "Data
Validation Failure")
End
End Sub

Pat, i tested rmcompute's code in an A2K db running in A2003 on OS Win2KPro.
i pasted it "as is" from his post, changing only the control name HRnum to
the name of a control on my form. the code runs fine on my setup. did you
have a different result? perhaps in another version of Access or Windows?

hth


"Pat Hartman(MVP)" wrote in message
...
Your code DOES NOT work!!!!

"rmcompute" wrote in message
...
When I re-tested, it seemed to work; I guess I had been working too
long.
Thank you.



"tina" wrote:

i tested your code on a Continuous form, and it ran consistently no
matter
what i did to "save" either a new record or an edit to an existing
record -
pressing Shift+Enter, or clicking the toolbar icon, or choosing menu
Records
| Save record, or moving to another record - either next or previous,
or
closing the form. this is the expected result.

are you sure that the new record is actually being saved when you "move
to
another record and click the Save icon"? what version of Access are you
using? and is any other code running on the form's BeforeUpdate event?

hth


"rmcompute" wrote in message
...
I set up the following code listed below. The form is set up as a
multi-record form (Default View = Continuous Forms). The test is
successful
on existing records preventing the user from going forward. When a
new
record is added, the user can beat the system by clicking on the next
line
and then clicking the save icon on the tool bar. Can the system be
set
up
in
such a way that if the user adds a new record and the test fails,
that
he
is
prevented from saving the record or even going to the next line by
clicking
the mouse. Could the toolbar be disabled, preventing the user from
being
able to save when the test fails ? Is any other code required in the
BeforeUpdate procedure to prevent the user from going forward until
the
error
is addressed ?

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
Cancel = MsgBox("You must enter an HR number.", vbCritical, "Data
Validation Failure")
End
End Sub

As I already said -
The value of vbCancel is 2
The value of True is -1

That means that if the user chooses the cancel button, the message box will
return a 2 and place that value in the Cancel argument. Access is expecting
0 or -1 as a value for the Cancel argument. If Cancel = -1, Access will
cancel the update. If Cancel is anything else (I'm assuming that that is
the way the test is coded), the record is saved. Therefore, if the record
is saved even when vbCancel is chosen, the code does not work!

Just because a piece of code compiles or doesn't raise an error, doesn't
mean that it is correct. Check the table and you will see the invalid
records there.

"tina" wrote in message
...
Pat, i tested rmcompute's code in an A2K db running in A2003 on OS
Win2KPro.
i pasted it "as is" from his post, changing only the control name HRnum to
the name of a control on my form. the code runs fine on my setup. did you
have a different result? perhaps in another version of Access or Windows?

hth


"Pat Hartman(MVP)" wrote in message
...
Your code DOES NOT work!!!!

"rmcompute" wrote in message
...
When I re-tested, it seemed to work; I guess I had been working too
long.
Thank you.



"tina" wrote:

i tested your code on a Continuous form, and it ran consistently no
matter
what i did to "save" either a new record or an edit to an existing
record -
pressing Shift+Enter, or clicking the toolbar icon, or choosing menu
Records
| Save record, or moving to another record - either next or previous,
or
closing the form. this is the expected result.

are you sure that the new record is actually being saved when you
"move
to
another record and click the Save icon"? what version of Access are
you
using? and is any other code running on the form's BeforeUpdate event?

hth


"rmcompute" wrote in message
...
I set up the following code listed below. The form is set up as a
multi-record form (Default View = Continuous Forms). The test is
successful
on existing records preventing the user from going forward. When a
new
record is added, the user can beat the system by clicking on the
next
line
and then clicking the save icon on the tool bar. Can the system be
set
up
in
such a way that if the user adds a new record and the test fails,
that
he
is
prevented from saving the record or even going to the next line by
clicking
the mouse. Could the toolbar be disabled, preventing the user from
being
able to save when the test fails ? Is any other code required in
the
BeforeUpdate procedure to prevent the user from going forward until
the
error
is addressed ?

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
Cancel = MsgBox("You must enter an HR number.", vbCritical,
"Data
Validation Failure")
End
End Sub

Pat, Tina,

I re-tested the code. As mentioned before it is placed in Sub
Form_BeforeUpdate.
When I set the Cancel variable to anything except False, I could not save
the record.
It keeps looping through the Before Update Procedure.

RMConfused.


"Pat Hartman(MVP)" wrote:

As I already said -
The value of vbCancel is 2
The value of True is -1

That means that if the user chooses the cancel button, the message box will
return a 2 and place that value in the Cancel argument. Access is expecting
0 or -1 as a value for the Cancel argument. If Cancel = -1, Access will
cancel the update. If Cancel is anything else (I'm assuming that that is
the way the test is coded), the record is saved. Therefore, if the record
is saved even when vbCancel is chosen, the code does not work!

Just because a piece of code compiles or doesn't raise an error, doesn't
mean that it is correct. Check the table and you will see the invalid
records there.

"tina" wrote in message
...
Pat, i tested rmcompute's code in an A2K db running in A2003 on OS
Win2KPro.
i pasted it "as is" from his post, changing only the control name HRnum to
the name of a control on my form. the code runs fine on my setup. did you
have a different result? perhaps in another version of Access or Windows?

hth


"Pat Hartman(MVP)" wrote in message
...
Your code DOES NOT work!!!!

"rmcompute" wrote in message
...
When I re-tested, it seemed to work; I guess I had been working too
long.
Thank you.



"tina" wrote:

i tested your code on a Continuous form, and it ran consistently no
matter
what i did to "save" either a new record or an edit to an existing
record -
pressing Shift+Enter, or clicking the toolbar icon, or choosing menu
Records
| Save record, or moving to another record - either next or previous,
or
closing the form. this is the expected result.

are you sure that the new record is actually being saved when you
"move
to
another record and click the Save icon"? what version of Access are
you
using? and is any other code running on the form's BeforeUpdate event?

hth


"rmcompute" wrote in message
...
I set up the following code listed below. The form is set up as a
multi-record form (Default View = Continuous Forms). The test is
successful
on existing records preventing the user from going forward. When a
new
record is added, the user can beat the system by clicking on the
next
line
and then clicking the save icon on the tool bar. Can the system be
set
up
in
such a way that if the user adds a new record and the test fails,
that
he
is
prevented from saving the record or even going to the next line by
clicking
the mouse. Could the toolbar be disabled, preventing the user from
being
able to save when the test fails ? Is any other code required in
the
BeforeUpdate procedure to prevent the user from going forward until
the
error
is addressed ?

Private Sub Form_BeforeUpdate(Cancel As Integer)
If IsNull(Me.HRnum) Then
Cancel = MsgBox("You must enter an HR number.", vbCritical,
"Data
Validation Failure")
End
End Sub