If this is your first visit, be sure to check out the FAQ by clicking the link above. You may have to register before you can post: click the register link above to proceed. To start viewing messages, select the forum that you want to visit from the selection below. |
|
|
Thread Tools | Display Modes |
#31
|
|||
|
|||
Check For Existing Record
Even if I want them to see the error before the form is complete?
"Douglas J. Steele" wrote: NO! It should be in the form's BeforeUpdate event, not the BeforeUpdate event of the individual controls. -- Doug Steele, Microsoft Access MVP http://I.Am/DougSteele (no private e-mails, please) "ridgerunner" wrote in message ... Thanks for posting your code. After much comparison back and forth with mine, I realized the MsgBox wasn't working used yours as a model. I think I need this in both controls BeforeUpdate event to make this work properly. What a long day. Private Sub InspDate_BeforeUpdate(Cancel As Integer) Dim strMessage As String If IsNull(DLookup("StoreNo", "[tblDMInspections]", _ "[InspDate] = " & Format(Forms![frmAddDMInspections]![InspDate], "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & Forms![frmAddDMInspections]![StoreNo])) = False Then MsgBox strMessage & "Store and Inspection Date already exist. Press ESC and start over." End If End Sub "Beetle" wrote: Here is the code I'm using, copied as is from my app; If IsNull(DLookup("InvoiceNumber", "tblDeliveries", "InvoiceNumber = """ & _ Me.txtInvoiceNumber & """ AND DealerID = " & Me.cboDealerID)) = False Then MsgBox strMsg, vbOKOnly + vbExclamation, "Duplicate Invoice" Cancel = True Me.txtInvoiceNumber.Undo End If It does exactly what I want, as long as the "False" is outside the parentheses. I'm using it in the Before Update of a control, not the form, but that shouldn't matter as to whether the code works or not. Keep in mind, I'm only making suggestions for things you can try, Perhaps there is some other factor that is causing your criteria not to evaluate correctly. -- _________ Sean Bailey "ridgerunner" wrote: Where do you have this located? I copied the code exactly into the BeforeUpdate event for the form and it does not trap the error. I would like to trap the error after data is entered into the Store and InspDate fields, but right now I would like to see it work anywhere. I may be off line for a while. "Beetle" wrote: When you moved the "False" outside the parentheses, did you keep the last parentheses, or was it deleted? It should look like; If IsNull(DLookup("StoreNo", "[tblDMInspections]", _ "[InspDate] = " & Format(Forms![frmAddDMInspections]![InspDate], "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & Forms![frmAddDMInspections]![StoreNo])) = False Then ^(double) strMessage = strMessage & "Store and Inspection Date already exist." End If See the notation where it should be double parentheses I did a quick test on one of my apps. If the False is outside the parentheses it works, if it's inside nothing happens. -- _________ Sean Bailey "ridgerunner" wrote: Below is what I have now and I am not receiving any error messages but it is not trapping the duplicates either. Private Sub Form_BeforeUpdate(Cancel As Integer) Dim strMessage As String If IsNull(DLookup("StoreNo", "[tblDMInspections]", _ "[InspDate] = " & Format(Forms![frmAddDMInspections]![InspDate], "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & Forms![frmAddDMInspections]![StoreNo]) = False) Then strMessage = strMessage & "Store and Inspection Date already exist." End If End Sub "Beetle" wrote: Do you have double parentheses at the end (just before the = False)? -- _________ Sean Bailey "ridgerunner" wrote: If I do that then I get the message Compile Error: Expected: list separator or ) "Beetle" wrote: Try moving the "False" outside the parentheses. Private Sub Form_BeforeUpdate(Cancel As Integer) If IsNull(DLookup("StoreNo", "[tblDMInspections]", _ "[InspDate] = " & Format(Forms![frmAddDMInspection]![InspDate], "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & Forms![frmAddDMInspections]![StoreNo])) = False Then strMessage = strMessage & "Store and Inspection Date already exist." End If -- _________ Sean Bailey "ridgerunner" wrote: Sorry about the "ord". I found out why the syntax error was popping up: I had to pull this "\#yyyy\-mm\-dd\#") & _ to the line above. I now do not received any syntax errors but the code is not catching a duplicate entry. This is how it looks now. I had to make a correction to the table name. Private Sub Form_BeforeUpdate(Cancel As Integer) If IsNull(DLookup("StoreNo", "[tblDMInspections]", _ "[InspDate] = " & Format(Forms![frmAddDMInspection]![InspDate], "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & Forms![frmAddDMInspections]![StoreNo]) = False) Then strMessage = strMessage & "Store and Inspection Date already exist." End If End Sub "ridgerunner" wrote: Yes, ord wrap is messing things up. "Then" is in the correct place in the property sheet or should I call it module, but this screen makes it look like it is one line down. At any rate, the code below is highlighted with I get the syntax error message. If IsNull(DLookup("StoreNo", "[DMInspections]", _ "[InspDate] = " & Format(Forms![frmAddDMInspection]![InspDate], "Douglas J. Steele" wrote: You may have fallen victim of word-wrap. Then is supposed to be on the line above, after = False) That's odd, though. It looks correct when I look at what I posted to you. -- Doug Steele, Microsoft Access MVP http://I.Am/DougSteele (no private e-mails, please) "ridgerunner" wrote in message ... I am sorry I missed seeing this earlier. I have the part about making certain that a store and a date are entered covered in a command button on the form. I copied and pasted the code but I am getting a syntax error message and "IF" through the "THEN" are in red when I run compile. Private Sub Form_BeforeUpdate(Cancel As Integer) If IsNull(DLookup("StoreNo", "[DMInspections]", _ "[InspDate] = " & Format(Forms![frmAddDMInspection]![InspDate], "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & Forms![frmAddDMInspections]![StoreNo]) = False) Then strMessage = strMessage & "Store and Inspection Date already exist." End If End Sub "Douglas J. Steele" wrote: Well, you'd put it in the same module as the rest of the code associated with the form. However, I agree with Klatuu that it probably makes more sense just to put the code in the form's BeforeUpdate event, as opposed to in the BeforeUpdate event of the two text boxes. Private Sub Form_BeforeUpdate(Cancel = True) Dim strMessage As String If IsNull(Me.StoreNo) Then strMessage = strMessage & "You must provide a Store Number." & vbCrLf End If If IsNull(Me.InspDate) Then strMessage = strMessage & "You must provide an Inspection Date." & vbCrLf End If If Len(strMessage) = 0 Then If IsNull(DLookup("StoreNo", "[YourTableName]", _ "[InspDate] = " & Format(Forms![YourFormName]![InspDate], "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & Forms![YourFormName]![StoreNo]) = False) Then strMessage = strMessage & "Store and Inspection Date already exist." End If End If If Len(strMessage) 0 Then Cancel = True MsgBox strMessage, vbCritical End If End Sub |
#32
|
|||
|
|||
Check For Existing Record
It is just my opinion but I prefer to notify a user as soon as they make a
mistake. My preference would be to have verification in the BeforeUpdate event of both controls and just check for missing entries in the BeforeUpdate event of the form. Just my $0.02. ridgerunner wrote: Even if I want them to see the error before the form is complete? NO! It should be in the form's BeforeUpdate event, not the BeforeUpdate event of the individual controls. [quoted text clipped - 227 lines] End Sub -- RuralGuy (RG for short) aka Allan Bunch MS Access MVP - acXP WinXP Pro Please post back to this forum so all may benefit. Message posted via AccessMonster.com http://www.accessmonster.com/Uwe/For...forms/200805/1 |
#33
|
|||
|
|||
Check For Existing Record
I am having another problem now. When I put data into the Store control,
before putting data in the InspDate control, I receive the following error message: Run-time error '3075': Syntax error (missing operator) in query expression '[InspDate]= AND [StoreNo] = 11'. Below is the code: Private Sub StoreNo_BeforeUpdate(Cancel As Integer) Dim strMessage As String If IsNull(DLookup("StoreNo", "[tblDMInspections]", _ "[InspDate] = " & Format(Forms![frmAddDMInspections]![InspDate], "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & Forms![frmAddDMInspections]![StoreNo])) = False Then MsgBox strMessage & "Store and Inspection Date already exist. Press Esc to correct." End If End Sub The arrow in the debug screen points to the line starting with AND. "ruralguy via AccessMonster.com" wrote: It is just my opinion but I prefer to notify a user as soon as they make a mistake. My preference would be to have verification in the BeforeUpdate event of both controls and just check for missing entries in the BeforeUpdate event of the form. Just my $0.02. ridgerunner wrote: Even if I want them to see the error before the form is complete? NO! It should be in the form's BeforeUpdate event, not the BeforeUpdate event of the individual controls. [quoted text clipped - 227 lines] End Sub -- RuralGuy (RG for short) aka Allan Bunch MS Access MVP - acXP WinXP Pro Please post back to this forum so all may benefit. Message posted via AccessMonster.com http://www.accessmonster.com/Uwe/For...forms/200805/1 |
#34
|
|||
|
|||
Check For Existing Record
You do not want to check for duplicates until *both* controls and been
completed. The first test should be to check if *both* controls have data. ridgerunner wrote: I am having another problem now. When I put data into the Store control, before putting data in the InspDate control, I receive the following error message: Run-time error '3075': Syntax error (missing operator) in query expression '[InspDate]= AND [StoreNo] = 11'. Below is the code: Private Sub StoreNo_BeforeUpdate(Cancel As Integer) Dim strMessage As String If IsNull(DLookup("StoreNo", "[tblDMInspections]", _ "[InspDate] = " & Format(Forms![frmAddDMInspections]![InspDate], "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & Forms![frmAddDMInspections]![StoreNo])) = False Then MsgBox strMessage & "Store and Inspection Date already exist. Press Esc to correct." End If End Sub The arrow in the debug screen points to the line starting with AND. It is just my opinion but I prefer to notify a user as soon as they make a mistake. My preference would be to have verification in the BeforeUpdate [quoted text clipped - 8 lines] End Sub -- RuralGuy (RG for short) aka Allan Bunch MS Access MVP - acXP WinXP Pro Please post back to this forum so all may benefit. Message posted via AccessMonster.com http://www.accessmonster.com/Uwe/For...forms/200805/1 |
#35
|
|||
|
|||
Check For Existing Record
That indicates that you've got a StoreNo, but no InspDate.
If you look at the snippets I posted earlier, I think you'll see that I used the Nz function to handle those cases: If IsNull(DLookup("StoreNo", "[tblDMInspections]", _ "[InspDate] = " & _ Format(Nz(Forms![frmAddDMInspections]![InspDate], #01/01/100#), _ "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & _ Nz(Forms![frmAddDMInspections]![StoreNo], 0))) = False Then All I'm doing is putting in a value that should never occur naturally, so it won't blow up the DLookup and won't return a duplicate. -- Doug Steele, Microsoft Access MVP http://I.Am/DougSteele (no e-mails, please!) "ridgerunner" wrote in message ... I am having another problem now. When I put data into the Store control, before putting data in the InspDate control, I receive the following error message: Run-time error '3075': Syntax error (missing operator) in query expression '[InspDate]= AND [StoreNo] = 11'. Below is the code: Private Sub StoreNo_BeforeUpdate(Cancel As Integer) Dim strMessage As String If IsNull(DLookup("StoreNo", "[tblDMInspections]", _ "[InspDate] = " & Format(Forms![frmAddDMInspections]![InspDate], "\#yyyy\-mm\-dd\#") & _ " AND [StoreNo] = " & Forms![frmAddDMInspections]![StoreNo])) = False Then MsgBox strMessage & "Store and Inspection Date already exist. Press Esc to correct." End If End Sub The arrow in the debug screen points to the line starting with AND. "ruralguy via AccessMonster.com" wrote: It is just my opinion but I prefer to notify a user as soon as they make a mistake. My preference would be to have verification in the BeforeUpdate event of both controls and just check for missing entries in the BeforeUpdate event of the form. Just my $0.02. ridgerunner wrote: Even if I want them to see the error before the form is complete? NO! It should be in the form's BeforeUpdate event, not the BeforeUpdate event of the individual controls. [quoted text clipped - 227 lines] End Sub -- RuralGuy (RG for short) aka Allan Bunch MS Access MVP - acXP WinXP Pro Please post back to this forum so all may benefit. Message posted via AccessMonster.com http://www.accessmonster.com/Uwe/For...forms/200805/1 |
Thread Tools | |
Display Modes | |
|
|